Skip to content
This repository has been archived by the owner on Mar 9, 2021. It is now read-only.

Hint requests are handled even when no hints can be shown #3

Closed
szdc opened this issue Dec 19, 2014 · 0 comments
Closed

Hint requests are handled even when no hints can be shown #3

szdc opened this issue Dec 19, 2014 · 0 comments
Assignees
Labels

Comments

@szdc
Copy link

szdc commented Dec 19, 2014

In your existing code, when hints are explicitly called on an attribute, you are returning true without checking whether you can actually provide hints for the attribute. This means your extension is handling hint sessions when it shouldn't be, causing extensions with lower priority to never get run.

I have created a pull request with a solution to a repository that forked yours, but I don't know how to make a pull request to yours with just my changes so I've created this issue.

@coliff coliff added the bug label May 31, 2017
@coliff coliff self-assigned this May 31, 2017
@coliff coliff closed this as completed Mar 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants