Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out of bounds index when trying to read string of rooms #44

Open
Miepee opened this issue May 2, 2022 · 0 comments
Open

Out of bounds index when trying to read string of rooms #44

Miepee opened this issue May 2, 2022 · 0 comments
Labels
bug Something isn't working serialization Issues pertaining to reading/writing GameMaker data files

Comments

@Miepee
Copy link
Contributor

Miepee commented May 2, 2022

A few games generate the following stacktrace trying to load them:

System.IndexOutOfRangeException: Index was outside the bounds of the array.
   at DogScepterLib.Core.GMDataReader.ReadGMString() in C:\Users\narr\gitrepos\dog-scepter\DogScepterLib\Core\GMDataReader.cs:line 229
   at DogScepterLib.Core.Models.GMString.Deserialize(GMDataReader reader) in C:\Users\narr\gitrepos\dog-scepter\DogScepterLib\Core\Models\GMString.cs:line 24
   at DogScepterLib.Core.GMDataReader.ReadPointerObject[T](Int32 ptr) in C:\Users\narr\gitrepos\dog-scepter\DogScepterLib\Core\GMDataReader.cs:line 128
   at DogScepterLib.Core.GMDataReader.ReadStringPointerObject() in C:\Users\narr\gitrepos\dog-scepter\DogScepterLib\Core\GMDataReader.cs:line 219
   at DogScepterLib.Core.Models.GMRoom.Layer.EffectProperty.Deserialize(GMDataReader reader) in C:\Users\narr\gitrepos\dog-scepter\DogScepterLib\Core\Models\GMRoom.cs:line 703
   at DogScepterLib.Core.GMList`1.Deserialize(GMDataReader reader, ListDeserialize before, ListDeserialize after, ListDeserializeElement elemReader) in C:\Users\narr\gitrepos\dog-scepter\DogScepterLib\Core\GMLists.cs:line 73
   at DogScepterLib.Core.GMList`1.Deserialize(GMDataReader reader) in C:\Users\narr\gitrepos\dog-scepter\DogScepterLib\Core\GMLists.cs:line 85
   at DogScepterLib.Core.Models.GMRoom.Layer.Deserialize(GMDataReader reader) in C:\Users\narr\gitrepos\dog-scepter\DogScepterLib\Core\Models\GMRoom.cs:line 431
   at DogScepterLib.Core.GMDataReader.ReadPointerObjectUnique[T](Int32 ptr, Boolean returnAfter) in C:\Users\narr\gitrepos\dog-scepter\DogScepterLib\Core\GMDataReader.cs:line 181
   at DogScepterLib.Core.GMPointerList`1.DoReadPointerObjectUnique(GMDataReader reader, Boolean notLast) in C:\Users\narr\gitrepos\dog-scepter\DogScepterLib\Core\GMLists.cs:line 167
   at DogScepterLib.Core.GMPointerList`1.Deserialize(GMDataReader reader, ListDeserialize before, ListDeserialize after, ListDeserializeElement elemReader) in C:\Users\narr\gitrepos\dog-scepter\DogScepterLib\Core\GMLists.cs:line
191
   at DogScepterLib.Core.GMPointerList`1.Deserialize(GMDataReader reader) in C:\Users\narr\gitrepos\dog-scepter\DogScepterLib\Core\GMLists.cs:line 199
   at DogScepterLib.Core.GMDataReader.ReadPointerObjectUnique[T](Int32 ptr, Boolean returnAfter) in C:\Users\narr\gitrepos\dog-scepter\DogScepterLib\Core\GMDataReader.cs:line 181
   at DogScepterLib.Core.GMDataReader.ReadPointerObjectUnique[T]() in C:\Users\narr\gitrepos\dog-scepter\DogScepterLib\Core\GMDataReader.cs:line 203
   at DogScepterLib.Core.Models.GMRoom.Deserialize(GMDataReader reader) in C:\Users\narr\gitrepos\dog-scepter\DogScepterLib\Core\Models\GMRoom.cs:line 135
   at DogScepterLib.Core.GMDataReader.ReadPointerObjectUnique[T](Int32 ptr, Boolean returnAfter) in C:\Users\narr\gitrepos\dog-scepter\DogScepterLib\Core\GMDataReader.cs:line 181
   at DogScepterLib.Core.GMPointerList`1.DoReadPointerObjectUnique(GMDataReader reader, Boolean notLast) in C:\Users\narr\gitrepos\dog-scepter\DogScepterLib\Core\GMLists.cs:line 167
   at DogScepterLib.Core.GMPointerList`1.Deserialize(GMDataReader reader, ListDeserialize before, ListDeserialize after, ListDeserializeElement elemReader) in C:\Users\narr\gitrepos\dog-scepter\DogScepterLib\Core\GMLists.cs:line
191
   at DogScepterLib.Core.GMPointerList`1.Deserialize(GMDataReader reader) in C:\Users\narr\gitrepos\dog-scepter\DogScepterLib\Core\GMLists.cs:line 199
   at DogScepterLib.Core.Chunks.GMChunkROOM.Deserialize(GMDataReader reader) in C:\Users\narr\gitrepos\dog-scepter\DogScepterLib\Core\Chunks\GMChunkROOM.cs:line 27
   at DogScepterLib.Core.GMChunkFORM.Deserialize(GMDataReader reader) in C:\Users\narr\gitrepos\dog-scepter\DogScepterLib\Core\GMChunk.cs:line 170
   at DogScepterLib.Core.GMDataReader.Deserialize(Boolean clearData) in C:\Users\narr\gitrepos\dog-scepter\DogScepterLib\Core\GMDataReader.cs:line 58
   at DogScepterCLI.ConsoleExtensions.LoadDataFile(IConsole console, String file, Boolean verbose) in C:\Users\narr\gitrepos\dog-scepter\DogScepterCLI\ConsoleExtensions.cs:line 127

Smash teh reds, incubination, growaway, non spacious oasis, stonks 9800, linna devotion to locomotion, dome run, island takeover, keeping the peace


Corby Glorg has a similar stacktrace happening on sprites. Not sure if related:

System.IndexOutOfRangeException: Index was outside the bounds of the array.
   at DogScepterLib.Core.GMDataReader.ReadGMString() in C:\Users\narr\gitrepos\dog-scepter\DogScepterLib\Core\GMDataReader.cs:line 229
   at DogScepterLib.Core.Models.GMString.Deserialize(GMDataReader reader) in C:\Users\narr\gitrepos\dog-scepter\DogScepterLib\Core\Models\GMString.cs:line 24
   at DogScepterLib.Core.GMDataReader.ReadPointerObject[T](Int32 ptr) in C:\Users\narr\gitrepos\dog-scepter\DogScepterLib\Core\GMDataReader.cs:line 128
   at DogScepterLib.Core.GMDataReader.ReadStringPointerObject() in C:\Users\narr\gitrepos\dog-scepter\DogScepterLib\Core\GMDataReader.cs:line 219
   at DogScepterLib.Core.Models.GMSprite.Deserialize(GMDataReader reader) in C:\Users\narr\gitrepos\dog-scepter\DogScepterLib\Core\Models\GMSprite.cs:line 144
   at DogScepterLib.Core.GMDataReader.ReadPointerObjectUnique[T](Int32 ptr, Boolean returnAfter) in C:\Users\narr\gitrepos\dog-scepter\DogScepterLib\Core\GMDataReader.cs:line 181
   at DogScepterLib.Core.GMPointerList`1.DoReadPointerObjectUnique(GMDataReader reader, Boolean notLast) in C:\Users\narr\gitrepos\dog-scepter\DogScepterLib\Core\GMLists.cs:line 167
   at DogScepterLib.Core.GMPointerList`1.Deserialize(GMDataReader reader, ListDeserialize before, ListDeserialize after, ListDeserializeElement elemReader) in C:\Users\narr\gitrepos\dog-scepter\DogScepterLib\Core\GMLists.cs:line
191
   at DogScepterLib.Core.GMPointerList`1.Deserialize(GMDataReader reader) in C:\Users\narr\gitrepos\dog-scepter\DogScepterLib\Core\GMLists.cs:line 199
   at DogScepterLib.Core.Chunks.GMChunkSPRT.Deserialize(GMDataReader reader) in C:\Users\narr\gitrepos\dog-scepter\DogScepterLib\Core\Chunks\GMChunkSPRT.cs:line 27
   at DogScepterLib.Core.GMChunkFORM.Deserialize(GMDataReader reader) in C:\Users\narr\gitrepos\dog-scepter\DogScepterLib\Core\GMChunk.cs:line 170
   at DogScepterLib.Core.GMDataReader.Deserialize(Boolean clearData) in C:\Users\narr\gitrepos\dog-scepter\DogScepterLib\Core\GMDataReader.cs:line 58
   at DogScepterCLI.ConsoleExtensions.LoadDataFile(IConsole console, String file, Boolean verbose) in C:\Users\narr\gitrepos\dog-scepter\DogScepterCLI\ConsoleExtensions.cs:line 127
@colinator27 colinator27 added bug Something isn't working serialization Issues pertaining to reading/writing GameMaker data files labels May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working serialization Issues pertaining to reading/writing GameMaker data files
Projects
None yet
Development

No branches or pull requests

2 participants