Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary zip file #3

Closed
rlorenzo opened this issue Mar 6, 2019 · 2 comments
Closed

Unnecessary zip file #3

rlorenzo opened this issue Mar 6, 2019 · 2 comments
Assignees

Comments

@rlorenzo
Copy link

rlorenzo commented Mar 6, 2019

In the deployment instructions it says:

  • Download this repository.
  • Extract the ZIP to 'mod/lti/source/'.
  • The folder name within the source directory should be "message_handler".
  • Login to your Moodle site as an administrator and install the plugin.

But the zip file in the repo appears to be the contents of the repo itself. Isn't it clearer to just rename the downloaded repo to message_handler and copy the folder to the mod/lti/source folder?

On our system we add plugins to our codebase using git submodules, so we would just create a submodule under mod/lti/source pointing to the master of this repo.

The extra, unnecessary zip file just adds bulk to the package.

@rlorenzo rlorenzo closed this as completed Mar 6, 2019
@rlorenzo rlorenzo reopened this Mar 6, 2019
@colinperepelken colinperepelken self-assigned this Mar 6, 2019
@colinperepelken
Copy link
Collaborator

Hi @rlorenzo,

Thank you for creating this issue! I removed the zip file from the repository and added a new version (2.8) to the Moodle Plugins Directory. I believe the deployment instructions still make sense, so I left those unchanged. Let me know if you have any other suggestions or concerns! If not, I'll go ahead and close this issue.

Colin

@rlorenzo
Copy link
Author

rlorenzo commented Mar 6, 2019

@colinbernard Yeah, there is a download as Zip option from Github, hopefully people know that already.

Thanks!

@rlorenzo rlorenzo closed this as completed Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants