Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closeAllConnections in getRetrosheet breaks knitr #1

Closed
cantpitch opened this issue Apr 27, 2020 · 2 comments
Closed

closeAllConnections in getRetrosheet breaks knitr #1

cantpitch opened this issue Apr 27, 2020 · 2 comments

Comments

@cantpitch
Copy link

Similar to this issue: https://stackoverflow.com/questions/41372927/isincompletecon-error-when-knitting-pdf, the closeAllConnections calls in getRetrosheet currently break knitr with the error:

Quitting from lines 105-106 (Chapter04.Rmd) 
Error in isIncomplete(con) : invalid connection
Calls: <Anonymous> ... evaluate_call -> handle_output -> <Anonymous> -> isIncomplete
Quitting from lines 105-106 (Chapter04.Rmd) 
Error in isOpen(con) : invalid connection
Calls: <Anonymous> ... <Anonymous> -> evaluate_call -> <Anonymous> -> isOpen
Execution halted
@colindouglas
Copy link
Owner

colindouglas commented Apr 27, 2020

Thanks for the report! This is caused by sloppy connection handling (on my part). I've pushed some small changes (ffd76ea) to get rid of the closeAllConnections() calls and instead close the specific connections. I'm going to hold off pushing these changes to CRAN until you can verify that it's working for you. Please use the development version:

devtools::install_github("colindouglas/retrosheet")

and let me know if this resolves your issue.. Also, please also let me know if you are encountering any "closing unused connection" warning messages.

@colindouglas
Copy link
Owner

Should be resolved in v1.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants