Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heading 2 bottom border is missing #137

Closed
agung2001 opened this issue Jun 2, 2023 · 3 comments
Closed

heading 2 bottom border is missing #137

agung2001 opened this issue Jun 2, 2023 · 3 comments

Comments

@agung2001
Copy link

agung2001 commented Jun 2, 2023

Environment

  • Obsidian Version : 1.3.5
  • Things Version : 2.1.9

Screenshot

Screenshot 2023-06-03 at 06 23 03

Problem

It seems that the bottom border is missing

Solution

I notice that u use h2 when styling the heading theme.css#LL296C1-L296C61
m not sure what happened but it seems the latest version of Obsidian doesn't use h2 for the heading it uses div instead
Screenshot 2023-06-03 at 06 29 19
maybe change theme.css#LL296C1-L296C61 to :

body .HyperMD-header.HyperMD-header-2.cm-line {
  border-bottom: 2px solid var(--background-modifier-border);
  width: 100%;
  padding-bottom: 2px;
}

it fixes the issue for me

I really like your theme man, thanks for sharing @colineckert 😄👍
Also how about setting up sass?
I think it'll help with the development of this theme

@colineckert
Copy link
Owner

hey @agung2001 sry for the delay! are you sure you don't have any other styling on the h2? i have the same theme and Obisdian versions and this is not an issue on my end.
Screenshot 2023-06-04 at 5 17 46 PM

also, are you using the style settings plugin? check you don't have the h2 underline toggle disabled
Screenshot 2023-06-04 at 5 18 32 PM

yep, thought about sass! good idea, just haven't had the time to explore futher

@agung2001
Copy link
Author

omg, thanks. the style settings plugin help. now it works like a charm 😄👍

well for the sass, actually I can help you with that.
I can create a fork for this repo and integrate sass
do u want me to do it?

@colineckert
Copy link
Owner

awesome, glad that fixed it! i'll close this issue. and sure, go for it. fork and create a PR and i will review it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants