Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comparison with Runtypes #407

Closed
yuhr opened this issue Apr 20, 2021 · 6 comments
Closed

Update comparison with Runtypes #407

yuhr opened this issue Apr 20, 2021 · 6 comments

Comments

@yuhr
Copy link
Contributor

yuhr commented Apr 20, 2021

Hi, I'm a collaborator of https://github.com/pelotom/runtypes. Some descriptions about Runtypes in README.md have become wrong now 馃槈

  • Missing object methods: (pick, omit, partial, deepPartial, merge, extend)
  • Missing nonempty arrays with proper typing ([T, ...T[]])
  • Missing lazy/recursive types
  • Missing promise schemas
  • Missing union & intersection schemas
  • Missing error customization
  • Missing record schemas (their "record" is equivalent to Zod "object")
@colinhacks
Copy link
Owner

Can you submit a PR here?

@colinhacks
Copy link
Owner

Updated.

@yuhr
Copy link
Contributor Author

yuhr commented Apr 25, 2021

Thanks, but the resulting section seems nonsense. I'm sorry for that I have not enumerated required changes exhaustively 馃ぃ The paragraph also needs to be updated like this:

Good type inference support , but limited options for object type masking (no .pick , .omit , .extend , etc.). No support for Record s (their Record is equivalent to Zod's object ). They DO support branded and readonly types, which Zod does not.

I'm up for filing a PR, but I'm not sure which branch I should send a request to.

@Pictor13
Copy link

Is this readme correction still pending for revision?

I suppose master is the target for a PR.

@yuhr
Copy link
Contributor Author

yuhr commented Jun 29, 2023

Yes, it's just been forgotten. Thanks for the reminder, I'll open a PR right now.

@yuhr
Copy link
Contributor Author

yuhr commented Jun 29, 2023

#2536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants