Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace "DEL" Commands with "UNLINK". #160

Merged
merged 3 commits into from Jan 18, 2023

Conversation

jonashrem
Copy link
Contributor

Implements #158

This PR replaces DEL Command with UNLINK command like I suggested in #158

Details about UNLINK can be found here https://redis.io/commands/unlink .

As noticed here redis/redis#1748 (comment) this will not change the behavior.

As there is no check of Redis version included, it will break Redis Versions < 4.0 through.

As Redis 4.0 was released on 2017-07-14 and Redis 3 went EOL with the Redis 5 on 2018-10-17, I don't expect this being an issue.

@jonashrem jonashrem changed the title replace "DEL" Commands with "UNLIKN". replace "DEL" Commands with "UNLINK". Aug 30, 2020
Copy link
Owner

@colinmollenhour colinmollenhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Changing the lua scripts requires updating the LUA_CLEAN_SH1 and LUA_GC_SH1 contants, though. It's been forever since I've had to do this.. @nemphys, what is your process for obtaining the new script hashes?

@nemphys
Copy link
Contributor

nemphys commented Mar 20, 2021

@colinmollenhour not anything fancy, I just add a temporary
Mage::log(sha1($script));
right after the script assignment line and copy it from the log.

@colinmollenhour colinmollenhour merged commit d87ca37 into colinmollenhour:master Jan 18, 2023
@colinmollenhour
Copy link
Owner

Finally merged! Sorry it took over 2 years...

@jonashrem
Copy link
Contributor Author

Thanks. I think we can close #158 than as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants