-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CSV imports compatible with a wider possibility of CSV files #40
Comments
@browning25 -- I was able to test using Chrome and OSX. Can you test Windows? |
I could not get the test file to upload. Can you double check to make sure I have the formatting correct? I tried every variation of CSV I could save the file as. No luck. (The attached file is XLSX, but I tried uploading CSV files, Github doesnt support CSV file sharing). |
@browning25 we're going to need to test that live. It's gotta work from a Windows machine to an actual server IMO |
@browning25 -- i made more changes. I'm still not 100% confident I can test this effectively though. Would you mind giving it another whirl? |
@ColinW520 -- I was able to successfully upload a CSV file.
I think this has been adequately addressed! |
Awesome. Download file button resolved tonight. Close it if you're satisfied! |
@ColinW520 -- I was able to download the spreadsheet. Only thing I noticed was that on my spreadsheet, it had Derek Schillaci's actual phone number on it. Is this the same spreadsheet that everyone will see when they download a sample file? If so, we need to change Derek's phone number just in case. Otherwise, looks great and ready to close. |
made changes and saved -- should be closable |
Verified the changes and ready to close. |
So, this isn't exactly a bug, but it's still aberrant behavior. The importer is currently extremely strict regarding the import file types it is willing to work with. Notably, it rejects anything that isn't a PURE CSV file, including Excel-exported csv's, plaintext csvs, and more. Believe it or not ( I know, it's stupid ) -- almost every word processing application encodes csv files differently...for some reason.
To make contact imports more useful for ALL, we need to accept a wider array of file types. This gets tricky -- because we still need to be able to parse the thing, and for that we need it to be amenable to csv-ish commands.
This is the first in a range of issues around imports, including better progress transparency, error messages, and more.
Here are the test cases we need to support:
Bonus points: write Meta tests that support these requirements.
The text was updated successfully, but these errors were encountered: