Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding season 33, new shorts data #67

Open
marikodes opened this issue Dec 23, 2022 · 4 comments
Open

Adding season 33, new shorts data #67

marikodes opened this issue Dec 23, 2022 · 4 comments

Comments

@marikodes
Copy link

I would like to help out by adding data for season 33, as well as the most recently released D+ shorts.

@colinxfleming
Copy link
Owner

colinxfleming commented Jan 16, 2023

hey @marikodes , thank you! I'd say let's point you toward the shorts first - I've been sticking those in episodes/season_theatrical.yml.

Below is a list of the fields and how to get em:

- title: Maggie Simpson in The Force Awakens from Its Nap # episode title
  season: 99 # I've been putting shorts in season 99
  episode: 5 # episode number
  release_date: # YYYY-MM-DD, can usually find this on wikipedia
  directors: # either credits of episode or wikipedia
  writers: # either credits of episode or wikipedia
  description: # get this from Disney+
  disneyplus_id: # the disney+ UUID
  simpsonsworld_id: # leave blank since simpsonsworld is gone
  good: # either true, false, or maybe
  guest_stars: # optional array of strings, can leave blank or [] if there aren't guest stars

@colinxfleming
Copy link
Owner

(let me know if you need a hand opening up a pull request on github, happy to help!)

@marikodes
Copy link
Author

Yes please! I am new to pull requests, I did visit the Github docs but it isn't quite clicking. Should I fork this repo and then create a pull request from the forked version (also is that where I would put the data)?

@colinxfleming
Copy link
Owner

yep! roughly the steps (if I remember right) are:

  • fork this repo
  • make your changes to that fork (either on a branch or on main, either good)
  • when your changes are ready, open a pull request to this repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants