Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use adapter.js #34

Closed
thijstriemstra opened this issue Jan 4, 2016 · 2 comments
Closed

Use adapter.js #34

thijstriemstra opened this issue Jan 4, 2016 · 2 comments

Comments

@thijstriemstra
Copy link
Member

The webrtc adapter.js provides a shim to insulate apps from browser spec changes and prefix differences.

Now that we also use media constraints it makes sense to include this adapter, even though an extra dependency should always be avoided, if possible. Perhaps the code can be adapted/included?

Besides the cross-browser constraint support it also helps with #16 and maybe #13.

@thijstriemstra
Copy link
Member Author

Perhaps core compatibility code for things like getUserMedia and MediaStream.stop() will always be part of videojs-record, but support for 'extras' like enumerateDevices (#16) or consistent constraints definitions you would need to include some or all of adapter.js (e.g. https://webrtc.github.io/adapter/adapter-latest.js).

@thijstriemstra
Copy link
Member Author

adapter.js isn't necessary for videojs-record until now so I'll close this. If you have troubles with e.g. media constraints across browers, you're free to include adapter.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant