Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No examples of videojs-record methods #5

Closed
pbojinov opened this issue Jul 2, 2015 · 2 comments
Closed

No examples of videojs-record methods #5

pbojinov opened this issue Jul 2, 2015 · 2 comments

Comments

@pbojinov
Copy link

pbojinov commented Jul 2, 2015

For those who are not very familiar with videojs, it is not obvious, at first, that you can access the methods through the recorder object on a video instance. @thijstriemstra would you accept a PR with an example HTML file documenting how to use them?

// create video
var player = videojs('myAudio', {
    controls: true,
    width: 600,
    height: 300,
    plugins: {
        record: {
            audio: true,
            video: false,
            maxLength: 20
        }
    }
});

// recorder methods available through `recorder` object
player.recorder.isRecording()
player.recorder.getRecordType()
player.recorder.destroy()
@pbojinov pbojinov changed the title Not clear how to use videojs-record methods No examples of videojs-record methods Jul 2, 2015
@thijstriemstra
Copy link
Member

hi @pbojinov, thanks for your feedback. If you could add these instructions to the README as well as the existing index.html, I will accept your PR, I would like to prevent adding more HTML example files.

@thijstriemstra
Copy link
Member

Closing, no feedback, feel free to open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants