Feat dpdkevents fixes #2348
Merged
Feat dpdkevents fixes #2348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current implementation attempts to open KA SHM only once during init callback. If at the time primary DPDK application is not running shm_open will fail, which will result in dpdkevents plugin being unloaded. Move KA SHM open logic to read callback to allow plugin to attach to primary DPDK application later without a need to restart collectd. Moreover, it will allow to determine if primary DPDK application was killed and plugin should stop dispatching KA statistics. Additionally modify dpdk_event_keep_alive_shm_open function to detect restart of primary DPDK application. When primary DPDK application (with KA support) is restarted it unlinks existing shared memory object and creates a new one. It's necessary for the plugin to create a new SHM mapping in order to prevent reading statistics from stale SHM block. Change-Id: I7fc0047ba117db771ada58a40cbe0b2bddd00112 Signed-off-by: Przemyslaw Szczerbik <przemyslawx.szczerbik@intel.com>
This patch removes impact of keep_alive init failure on link_status processing. Also changed default behaviour in configless mode, where no <Plugin/> stanza is defined. Now both keep_alive and link_status are enabled by default. On the other hand if <Plugin/> stanza is present, both features are disabled by default and user is responsible for specifying which one is active or not. Change-Id: I03f7ab88e89404e03532677d00a966ddb80d1552 Signed-off-by: Krzysztof Matczak <krzysztofx.matczak@intel.com>
- Do not return error in configuration callback, which will cause collectd to be stopped. Instead, report error in init callback, which will unload incorrectly configured plugin. - Remove redundant ProcessType configuration option, which was always set to "secondary" - Use functions from cf_util_get family for parsing config file - In case of parsing errors perform plugin cleanup - Correctly remove previously created shared memory object if user specified "SharedMemObj" option with different value than default - Prevent segmentation fault in dpdk_shm_cleanup - Change 'send_updated' and 'notify' variable types to _Bool Change-Id: Id7dfc7f25d2cebf332d47bcd5afaaebf577945d6 Signed-off-by: Przemyslaw Szczerbik <przemyslawx.szczerbik@intel.com>
|
Thanks @maryamtahhan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following fixes: