network,exec: fix memory issue #3310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can happen with more than 1 WriteThreads
yousong
changed the title
rubenk
approved these changes
Oct 29, 2019
rpv-tomsk
added a commit
to rpv-tomsk/collectd
that referenced
this pull request
Mar 21, 2020
Data race conditions explanation in collectd#3310 is a bit incorrect. The `network_send_buffer()` where `se->lock` was added in c44c159, is called by chain `network_write() -> flush_buffer()`. The `network_write()` could be called from multiply threads, but it has `send_buffer_lock`, so all calls to `network_send_buffer()` are serialized and there is no data race. The issue could be caused by second possible call path, `network_notification()->network_send_buffer()`. There is no lock, so race can occur. Notifications are sent rarely, so lock on each socket entry is inefficient. Related: collectd#3310 Reworks: c44c159
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: exec plugin: fix memory reclamation at plugin shutdown
Changelog: network plugin: fix data race accessing sending_sockets
These were spotted with the help from AddressSanitizer.