Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix coding style #3397

Merged
merged 1 commit into from Mar 4, 2020
Merged

Fix coding style #3397

merged 1 commit into from Mar 4, 2020

Conversation

dago
Copy link
Contributor

@dago dago commented Mar 4, 2020

ChangeLog: plugin df: Coding style fixes

@dago
Copy link
Contributor Author

dago commented Mar 4, 2020

This PR fixes coding style issues introduced in #2910
@rpv-tomsk thanks for noticing!

@dago dago requested a review from rpv-tomsk March 4, 2020 09:30
@kwiatrox
Copy link
Member

kwiatrox commented Mar 4, 2020

Looks very good, but shouldn't it go to collectd-5.11 branch? @mrunge can you response on that?

@rpv-tomsk
Copy link
Contributor

You overplayed with rules and policies.
You need managers who will point you what to do, or you will simply do what will work? Or you do not trust yourself?

@rpv-tomsk
Copy link
Contributor

Ah, I forget - you have no permissions to merge your own PR.... Sorry...
Really serious change - eight parenthesis removed from code, such a critical change.

@mrunge
Copy link
Member

mrunge commented Mar 4, 2020

Looks very good, but shouldn't it go to collectd-5.11 branch? @mrunge can you response on that?

Should go to both.

@dago dago merged commit b5eff86 into collectd:master Mar 4, 2020
@mrunge
Copy link
Member

mrunge commented Mar 4, 2020

Ah, I forget - you have no permissions to merge your own PR.... Sorry...
Really serious change - eight parenthesis removed from code, such a critical change.

Could you please stop that behaviour. It does not help anything.

@rpv-tomsk
Copy link
Contributor

rpv-tomsk commented Mar 4, 2020 •
edited

I will not stop at your request. You can ignore it if you want and you can.
If you can't - that is only your problem.

@rpv-tomsk
Copy link
Contributor

3 hours to remove eight parenthesis. Really fast work.
Will see how much time takes to implement real code changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunge mrunge mrunge approved these changes

@rpv-tomsk rpv-tomsk Awaiting requested review from rpv-tomsk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dago @kwiatrox @rpv-tomsk @mrunge