Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

w_prometheus: fix libmicrohttpd api change #3514

Merged
merged 2 commits into from Jul 24, 2020
Merged

w_prometheus: fix libmicrohttpd api change #3514

merged 2 commits into from Jul 24, 2020

Conversation

bzed
Copy link
Contributor

@bzed bzed commented Jul 24, 2020 •
edited by mrunge

ChangeLog: write_prometheus: fix libmicrohttpd api change

Closes #3511

@bzed bzed requested a review from a team as a code owner July 24, 2020 09:00
mrunge
mrunge reviewed Jul 24, 2020
View reviewed changes
Copy link
Member

@mrunge mrunge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good to me. Not approving this until clang format passes.

@mrunge
Copy link
Member

mrunge commented Jul 24, 2020

Thank you for the quick fix. Could you please run

contrib/format.sh src/write_prometheus.c

?

@bzed
Run contrib/format.sh src/write_prometheus.c.
66407ef 
Fixing things I did not touch.
@bzed
Copy link
Contributor Author

bzed commented Jul 24, 2020

@mrunge well, done. that changed some lines I didn't even touch.

mrunge
mrunge approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@mrunge mrunge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again.

Yes, it is known that clang-format changes locations you didn't even look at :-/

@mrunge mrunge merged commit d9a4d69 into collectd:main Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunge mrunge mrunge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

libmicrohttpd API change in 0.9.71
2 participants
@bzed @mrunge