Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[collectd 6] Migrate the zfs_arc plugin #3757

Open
2 of 5 tasks
octo opened this issue Sep 24, 2020 · 0 comments
Open
2 of 5 tasks

[collectd 6] Migrate the zfs_arc plugin #3757

octo opened this issue Sep 24, 2020 · 0 comments
Assignees
Projects
Milestone

Comments

@octo
Copy link
Member

octo commented Sep 24, 2020

This is a tracking issue for migrating the zfs_arc plugin to collectd 6. Progress is tracked in the collectd 6 project. Technical guidance for migrating plugins to collectd 6 is provided in the V5 to V6 migration guide topic in the wiki.

Build status: Success

The zfs_arc plugin currently compiles, likely thanks to the backwards compatibility layer.

While the backwards compatibility layer allows the plugin to compile, it likely results in suboptimal metric names. If possible, try to find a Prometheus exporter reporting the same metric(s) and use the same naming schema.

Next steps

This is an automatically generated todo list. If one of the following steps doesn't make sense, blame the automation. 🙈

  • Assign this issue to yourself.
  • Determine whether the zfs_arc plugin should be migrated in the first place. If this is not an obvious "yes", discuss on the mailing list or at the next community call.
  • If possible, try to find a Prometheus exporter reporting the same metric(s) and use the same naming schema.
  • Update the zfs_arc plugin to produce a metric_family_t and call plugin_dispatch_metric_famliy(). For technical guidance, refer to the V5 to V6 migration guide. You can use the write_log plugin to verify that the produced metrics look as expected.
  • Create a pull request referencing this issue, based on the collectd-6.0 branch.
@octo octo added this to the 6.0 milestone Sep 24, 2020
@octo octo added this to To do in collectd 6 Sep 24, 2020
@dago dago self-assigned this Sep 26, 2020
@dago dago removed the help wanted label Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
collectd 6
  
To do
Development

No branches or pull requests

2 participants