Add support for varnish 4.x #783
Conversation
Summary of changes: - connections: "accepted" & "dropped" are now found in the session section - dirdns: doesn't exist in varnish 4 anymore - objects: "n_obj*" were removed from varnish 4 - ban: "obj", "req" & "completed" bans were added. As a lot of new "tested" metrics are available, so we only collectd the overall total now - session: metrics from "connections" and "threads" categories were moved here - struct: "n_sess*" were removed - totals: new, more detailed *bytes metrics were made available - threads: new metrics were made available. "queued" was moved the session section.
Affects Varnish 3 only.
Consitently alphabetically ordered options and ensured all version limitations are mentioned.
|
@mfournier I think it's good to go. |
|
Worked for me, 👍 |
|
Thanks for the feedback ! At least 2 other persons are using this patchset, and have reported being happy with it. So I'm merging this in. |
Add support for varnish 4.x
|
Thanks @mfournier 🎉 |
|
Is there any chance of this getting backported to 5.4? Updating to varnish 4 and have no collectd monitoring ability right now with it. I was hoping 5.4.2 was going to have it added. |
|
👍 I spent a couple of hours yesterday trying to figure out why the new 5.4.2 release wasn't compiling properly against varnish4, before I realised this patch hadn't been included. |
|
FYI, I was able to get it to compile against 5.4.2 and am receiving varnish 4 data using the following: |
I built this patchset against libvarnishapi 2.0.6, 3.0.2 and 4.0.2, but I didn't have the opportunity to run it on production varnishes yet. As the changes are well confined inside
#ifdefblocks, I'm pretty confident that any problem possibly introduced here would be limited to varnish 4.x.Would fix #618