libstatgrab: correctly detect new signature for sg_disk_io_stats()
#807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable `-Werror` to turn the warning into an error. I would have loved using `-Werror=incompatible-pointer-types` but it is only supported with very recent versions of gcc. Otherwise, it would just throw an error.
vincentbernat
referenced
this pull request
in vincentbernat/collectd
Nov 17, 2014
… 0.9 In those versions, `sg_get_disk_io_stats()` need to be invoked a pointer to size_t instead of pointer to int. Such a requirement is detected at configure-time. Fixes: collectd#445
|
This is a bit brittle, there's a good chance configure.ac might generate code with warnings. :person_frowning: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable
-Werrorto turn the warning into an error. I would have lovedusing
-Werror=incompatible-pointer-typesbut it is only supported withvery recent versions of gcc. Otherwise, it would just throw an error.
Also see #806 for an alternate solution. I think that #806 is better because relying on
-Werrorto only trigger an error on signature mismatch seems fragile. We could get other kind of warnings, like "comparison always true" when compilers will get smarter.