Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering Comment: URLToHyperlink #44

Closed
ksuess opened this issue Dec 3, 2014 · 1 comment
Closed

Rendering Comment: URLToHyperlink #44

ksuess opened this issue Dec 3, 2014 · 1 comment

Comments

@ksuess
Copy link
Member

ksuess commented Dec 3, 2014

Can we exclude the character ")" of URL transformation?
A Text like

... documentation (http://docs.plone.org) ...

would be nice to render as

... documentation (<a href="http://docs.plone.org">http://docs.plone.org</a>) ...

and not as it is now:

.. documentation (<a href="http://docs.plone.org)">http://docs.plone.org)</a> ...

See class URLToHyperlink urlmatcher.
Maybe there are more characters to exclude?

@jean
Copy link
Member

jean commented Dec 4, 2014

Hmm this is potentially complicated. Characters like ().,[]/"? are all valid in URLs. A ) could be excluded if the http is preceded by a matching (, but even then if the URL happens to include more brackets it could lead to breakage.

One easy way out may be to allow URLs to be delimited by backticks.

@ksuess ksuess closed this as completed Jan 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants