UI inconsistency on configuration modals

[hvelarde]

when configuring a tile we have a title on the modal and Save and Cancel buttons:

when configuring a row or column we have no title on the modal and no Save and Cancel buttons, but a close modal one:

this also relates to #127

[djowett]

Also "Choose Class" should be "Choose Class for Column" or "Choose Class for Row" depending which icon you clicked. (Note they are quite close together)

[djowett]

The lack of Save & Cancel buttons is to do with the implementation choice for fixing 284 - it was done with JQuery, if you want Save & Cancel buttons then you probably want a Schema interface as done in branch issue_284_a - but that was a bit slower to run.

Note the column size popup doesn't have Save or Cancel buttons either.

I'm not saying I disagree with you here, just making points!

[hvelarde]

we need to use one consistent UI in the package; I don't like the lack of Save and Cancel buttons

[djowett]

@hvelarde Just coming back to this... I don't like the lack of Save & Cancel buttons either...

Also this "Choose Class" requester doesn't save unless you click the "Saved" button on the main page after closing the requester.

@rodfersou any thoughts?

[hvelarde]

@djowett mmm, that's bad and we need to fix it before the release of the feature will be useless.

right now we are doing some work on another package but we'll be back soon on this.

I think I'm going to create the branch to remove the carousel tile in the following days.

@rodfersou a good article about the topic http://www.nngroup.com/articles/efficiency-vs-expectations/

[rodfersou]

@hvelarde @djowett agree to have consistent UI here, we should look into the resize tile button too, it uses the same jquery ui package and saves just the same way the class configuration does.

[rodfersou]

I didn't change it before because I need to learn better how prep overlay works..

[djowett]

Just checking up further on my statement above:

Also this "Choose Class" requester doesn't save unless you click the "Saved" button on the main page after closing the requester.

@rodfersou you are correct that this is not different to the resize tile button, however the resize tile button DOES highlight this by changing the "Saved" button to "Save".
I think all that's required to make this work is adding

 le.trigger('modified.layout');

somewhere after:

 $(document).on('change', '#class-chooser select', function(e) {

But I would like your thoughts on that.

[rodfersou]

@djowett I didn't notice that, I think it is easier to change button name first, and after we can replace all dialogs

@hvelarde do you think it is fair enough follow this path?

[djowett]

@rodfersou le.trigger('modified.layout'); will change the button name for you.

[rodfersou]

@djowett 👍

[hvelarde]

@rodfersou it's fair for now, but we need to inform the user that changes have been made if she tries to leave the page without saving the layout