Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover behaviors should have purge="false" #638

Open
idgserpro opened this issue Aug 10, 2016 · 3 comments
Open

Cover behaviors should have purge="false" #638

idgserpro opened this issue Aug 10, 2016 · 3 comments

Comments

@idgserpro
Copy link
Member

Just removing plone.app.stagingbehavior in collective.cover:

651cf0b
3c5b9da

... shouldn't give any problems for websites that already had old versions installed (like 1.0a6), because plone.app.stagingbehavior.interfaces.IStagingSupport (or any other additional behavior) would already be at cover portal_types definition.

Problem is that you have an upgradeStep that calls typeinfo again, so the behaviors in collective.cover overrides what we already had in ZODB. If you decide to call typeinfo again in the future, it would be safer to use purge="false".

@hvelarde
Copy link
Member

no longer an issue as the upgrade step has been removed.

@hvelarde
Copy link
Member

in fact this is still an issue that must be fixed in 1.x.

@hvelarde
Copy link
Member

now this is fixed in 1.x; we will need a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants