Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop code-analysis, add other QA checks #63

Closed
mauritsvanrees opened this issue Sep 9, 2022 · 1 comment
Closed

Drop code-analysis, add other QA checks #63

mauritsvanrees opened this issue Sep 9, 2022 · 1 comment
Assignees

Comments

@mauritsvanrees
Copy link
Member

I mostly care that isort and black are in order. plone.recipe.codeanalysis can be tricky to configure right for this, and not much seems to happen in that repo anymore.
There is https://github.com/plone/code-analysis-action now, using https://github.com/plone/code-quality

@mauritsvanrees
Copy link
Member Author

If I run pyupgrade --py38-plus and run bin/code-analysis, it gives these outdated errors, one of the reasons to get rid of it:

/Users/maurits/community/collective.recipe.backup/src/collective/recipe/backup/config.py:1:1: C101 Coding magic comment not found
/Users/maurits/community/collective.recipe.backup/src/collective/recipe/backup/__init__.py:1:1: C101 Coding magic comment not found
/Users/maurits/community/collective.recipe.backup/src/collective/recipe/backup/__init__.py:180:17: P101 format string does contain unindexed parameters
/Users/maurits/community/collective.recipe.backup/src/collective/recipe/backup/__init__.py:263:36: P101 format string does contain unindexed parameters
/Users/maurits/community/collective.recipe.backup/src/collective/recipe/backup/__init__.py:266:42: P101 format string does contain unindexed parameters
/Users/maurits/community/collective.recipe.backup/src/collective/recipe/backup/__init__.py:268:46: P101 format string does contain unindexed parameters
/Users/maurits/community/collective.recipe.backup/src/collective/recipe/backup/__init__.py:271:48: P101 format string does contain unindexed parameters
/Users/maurits/community/collective.recipe.backup/src/collective/recipe/backup/__init__.py:274:43: P101 format string does contain unindexed parameters
/Users/maurits/community/collective.recipe.backup/src/collective/recipe/backup/__init__.py:279:25: P101 format string does contain unindexed parameters
/Users/maurits/community/collective.recipe.backup/src/collective/recipe/backup/__init__.py:284:25: P101 format string does contain unindexed parameters
/Users/maurits/community/collective.recipe.backup/src/collective/recipe/backup/__init__.py:289:25: P101 format string does contain unindexed parameters
/Users/maurits/community/collective.recipe.backup/src/collective/recipe/backup/__init__.py:361:21: P101 format string does contain unindexed parameters
/Users/maurits/community/collective.recipe.backup/src/collective/recipe/backup/__init__.py:372:21: P101 format string does contain unindexed parameters
/Users/maurits/community/collective.recipe.backup/src/collective/recipe/backup/__init__.py:381:25: P101 format string does contain unindexed parameters
/Users/maurits/community/collective.recipe.backup/src/collective/recipe/backup/__init__.py:386:21: P101 format string does contain unindexed parameters
/Users/maurits/community/collective.recipe.backup/src/collective/recipe/backup/__init__.py:394:25: P101 format string does contain unindexed parameters
/Users/maurits/community/collective.recipe.backup/src/collective/recipe/backup/__init__.py:400:21: P101 format string does contain unindexed parameters
/Users/maurits/community/collective.recipe.backup/src/collective/recipe/backup/copyblobs.py:1:1: C101 Coding magic comment not found
/Users/maurits/community/collective.recipe.backup/src/collective/recipe/backup/copyblobs.py:235:12: P101 format string does contain unindexed parameters
/Users/maurits/community/collective.recipe.backup/src/collective/recipe/backup/copyblobs.py:1409:15: P101 format string does contain unindexed parameters
/Users/maurits/community/collective.recipe.backup/src/collective/recipe/backup/utils.py:1:1: C101 Coding magic comment not found
/Users/maurits/community/collective.recipe.backup/src/collective/recipe/backup/main.py:1:1: C101 Coding magic comment not found
/Users/maurits/community/collective.recipe.backup/src/collective/recipe/backup/main.py:226:29: P101 format string does contain unindexed parameters
/Users/maurits/community/collective.recipe.backup/src/collective/recipe/backup/main.py:231:33: P101 format string does contain unindexed parameters
/Users/maurits/community/collective.recipe.backup/src/collective/recipe/backup/repozorunner.py:1:1: C101 Coding magic comment not found
/Users/maurits/community/collective.recipe.backup/src/collective/recipe/backup/tests/test_docs.py:1:1: C101 Coding magic comment not found
/Users/maurits/community/collective.recipe.backup/src/collective/recipe/backup/tests/test_docs.py:41:22: P101 format string does contain unindexed parameters
/Users/maurits/community/collective.recipe.backup/src/collective/recipe/backup/tests/__init__.py:1:1: C101 Coding magic comment not found
/Users/maurits/community/collective.recipe.backup/src/collective/recipe/backup/tests/test_unit.py:1:1: C101 Coding magic comment not found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant