Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semver not available in runtime environment, reverted #129 #131

Closed
fredvd opened this issue Mar 22, 2024 · 1 comment
Closed

semver not available in runtime environment, reverted #129 #131

fredvd opened this issue Mar 22, 2024 · 1 comment
Assignees

Comments

@fredvd
Copy link
Member

fredvd commented Mar 22, 2024

@ericof You merged #129 , but semver is not available on runtime. @sneridagh Tried to fix this by using a hook install semver, but couldn't get it working, so I reverted the change for now.

The tests didn't catch this because they are using the requirement.txt to install semver, this does not happen when I call the template from a locally installed cookiecutter. Trying a hook to install it using pipx assumes / binds the template to using pipx always, but this doesn't have to be the case.

The most straightforward solution would imho be to make semver a dependency of cookiecutter itself and give it a new release. But cookiecutter seems to be lean on (no?) dependencies itself.

@davisagli
Copy link
Member

Fixed in #132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants