Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tox.ini extras declared in wrong way #285

Closed
jensens opened this issue Feb 6, 2019 · 0 comments · Fixed by #340
Closed

tox.ini extras declared in wrong way #285

jensens opened this issue Feb 6, 2019 · 0 comments · Fixed by #340

Comments

@jensens
Copy link
Member

jensens commented Feb 6, 2019

I just found that the extras are declared in a wrong way preventing the usedevelop setting (because it get installed prior as sdist).

https://github.com/collective/icalendar/blob/master/tox.ini#L10

Instead of declaring extras as .[test] in deps it should be declared in extras like

extras = 
    test

see tox docs extras, usedevelop and deps.
https://tox.readthedocs.io/en/latest/config.html#tox-environment-settings
@jensens jensens changed the title tox.ini extras decalred in wrong way tox.ini extras declared in wrong way Feb 6, 2019
@jacadzaca jacadzaca linked a pull request Sep 5, 2022 that will close this issue
Use GitHub Actions. Drop 3.4, 3.5, PyPy2 #340
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use GitHub Actions. Drop 3.4, 3.5, PyPy2 collective/icalendar
2 participants
@jensens @jacadzaca