Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the list of providers on an alternative way and improved regexes for getting the url #66

Open
idgserpro opened this issue Nov 11, 2016 · 0 comments

Comments

@idgserpro
Copy link
Member

idgserpro commented Nov 11, 2016

See https://github.com/simplesconsultoria/sc.embedder/blob/262d279b25878d11706eb25c9b94a699789ed4e5/src/sc/embedder/utility.py#L7

The way it's implemented right now for example gives the following error for https links in some providers:

2020-01-13 16:44:19 INFO sc.embedder There are no endpoints available for https://vimeo.com/384531827

Don't know if it's possible, but I would suggest taking https://github.com/itteco/iframely/blob/master/lib/plugins/system/oembed/providers.json inside the package and creating a dictionary that has these validations at runtime: upgrading the providers would mean just downlading a new json and adding it to the package. Using this approach we fix the regex problem as well since they are improved.

@idgserpro idgserpro changed the title Get the list of providers on an alternative way Get the list of providers on an alternative way and improved regexes for getting the url Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant