Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request builder creates platform dependent results #39

Open
datakurre opened this issue Oct 9, 2018 · 0 comments
Open

Request builder creates platform dependent results #39

datakurre opened this issue Oct 9, 2018 · 0 comments

Comments

@datakurre
Copy link
Collaborator

FYI, I couldn't get the snapshot tests to work on my mac. It looks like the output of this line may be slightly platform dependent?

I get almost the same results, but with some extra whitespace, as well as extra commas in data structures (e.g. {'k1': 'v1', 'k2': 'v2', } vs {'k1': 'v1', 'k2': 'v2'} in your snapshots).

To be clear, the resulting commands are equivalent, but the string representations are different, causing a bunch of failures.

Conversely, I had to manually edit the snapshot file instead of generating it automatically.

Originally posted by @ludaavics in #38 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant