Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postrelease should not check for towncrier fragments #16

Closed
mauritsvanrees opened this issue Mar 5, 2019 · 2 comments
Closed

postrelease should not check for towncrier fragments #16

mauritsvanrees opened this issue Mar 5, 2019 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@mauritsvanrees
Copy link
Member

I just released zestreleaser.towncrier 1.0.3. (Ah, should have been 1.1.0...) During postrelease, the new check was needlessly done:

INFO: Starting postrelease.
Found 0 towncrier newsfragments with recognized extension.

WARNING: No towncrier newsfragments found.
The changelog will not contain anything interesting.

Do you want to continue anyway? (y/N)?  y
INFO: Doing dry-run of towncrier to see what would be changed: /Users/maurits/community/zestreleaser.towncrier/bin/towncrier --draft --version t.b.d. --yes
...

We should not run the check during postrelease.
(A warning that some snippets have been left behind could be okay, but should be superfluous.)

@mauritsvanrees mauritsvanrees added the bug Something isn't working label Mar 5, 2019
@mauritsvanrees mauritsvanrees self-assigned this Mar 5, 2019
@mauritsvanrees
Copy link
Member Author

For good measure, I have created a branch 1.0.x and rereleased 1.0.2 as 1.0.4, to avoid the new features.
I have rereleased master as 1.1.0.

@mauritsvanrees
Copy link
Member Author

Fix released in 1.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant