Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Negative tag syntax ~@search is not compatible with cucumber 4 #37

Closed
rvalladares77 opened this issue Sep 1, 2020 · 2 comments · Fixed by #38
Closed

Negative tag syntax ~@search is not compatible with cucumber 4 #37

rvalladares77 opened this issue Sep 1, 2020 · 2 comments · Fixed by #38

Comments

@rvalladares77
Copy link

sunspot_test/lib/sunspot_test/cucumber.rb is using a cucumber old style tag expressions. the ~ for negative tags was removed in the version 4 , so according to cucumber documentation, it should be not @search instead of ~@search
@jonkerz jonkerz mentioned this issue Sep 21, 2020
Merged
@rvalladares77
Copy link
Author

@jonkerz @manlycode First of all, I want to thank you for your valuable help in creating this PR#38 for this issue.

I see it was merged, so I tried to upgrade my gem to the newest version 0.4.2 but I am getting this:

Bundler attempted to update sunspot_test but its version stayed the same

And also this website https://rubygems.org/gems/sunspot_test shows only the version 0.4.1, Is the version 0.4.2 actually available?

@manlycode
Copy link
Contributor

@rvalladares77 Sorry for the delay. I bumped the 0.4.2 version on ruby gems.org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use new-style tag expressions to support Cucumber 4 jonkerz/sunspot_test
2 participants
@manlycode @rvalladares77