use destroyById #219

dmtw · 2017-02-19T12:11:31Z

beeman

@dmtw thanks a lot for your contribution! 2 very minor changes and it's ready to merge through 👍

beeman · 2017-02-19T13:48:10Z

admin/src/app/content/products/products.component.ts

@@ -71,6 +71,7 @@ export class ProductsComponent {
  }

  action(event) {
+    console.log('event',event);


console.log

beeman · 2017-02-19T13:48:18Z

admin/src/app/content/products/products.component.ts

@@ -94,8 +95,9 @@ export class ProductsComponent {
        this.save(event.item)
        break
      case 'delete':
+        console.log('delete');


console.log

beeman · 2017-02-19T15:17:39Z

Another minor comment, could you please change the commit message to the desired format:

Like: fix(admin): use destroyById to delete content items)

Thanks!

beeman · 2017-02-19T19:33:51Z

Thanks for the changes @dmtw, merged it through and added you as contributor.

use destroyById

3deb8fc

beeman suggested changes Feb 19, 2017

View reviewed changes

fix(admin): use destroyById to delete content items)

c7570d3

beeman merged commit 1955a91 into colmena:develop Feb 19, 2017

Provide feedback