Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OKHSV and OKHSL #312

Closed
mattdesl opened this issue May 15, 2023 · 1 comment · Fixed by #469
Closed

OKHSV and OKHSL #312

mattdesl opened this issue May 15, 2023 · 1 comment · Fixed by #469
Assignees

Comments

@mattdesl
Copy link

It would be nice to have support for OKHSV and OKHSL, I find OKLCH challenging to work for color picking.

I have written basic support for OKHSV and OKHSL color spaces within color.js, you can see it here:

https://github.com/mattdesl/workshop-generative-color/blob/f5a26247fac7e6dc617f05fd23886a3bba6b5d4b/lib/color.js#L10-L81

and using the color conversion tools here:

https://github.com/mattdesl/workshop-generative-color/blob/f5a26247fac7e6dc617f05fd23886a3bba6b5d4b/lib/oklab.js

These conversions are only slightly modified and stripped down from Björn's color picker code, see here:

https://github.com/bottosson/bottosson.github.io/blob/master/misc/colorpicker/colorconversion.js (MIT license, as far as I can see)

@LeaVerou
Copy link
Member

Hi there,
We’d happily merge a PR on this. Do you think you might be able to send one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants