You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I suspect that this work-around might be the culprit:
check: check.deep(function(actual,expect){if(expect===null||Number.isNaN(expect)){// Treat NaN and null as equivalent for nowreturnactual===null||Number.isNaN(actual);}
weirdly the third sub-test still passes.
Note to self: (unrelated to this bug) the white test should be corrected, we now calculate a chroma of 0 rather than the slightly-off chroma of 0.0146 due to #354 which also means we can improve the rather slack epsilon in this test)
The text was updated successfully, but these errors were encountered:
In the new color conversions tests:
white | 100, 0, null | 100, 0.0146,notice the missing third parameter in the expected result.
The actual js lists the third parameter:
I suspect that this work-around might be the culprit:
weirdly the third sub-test still passes.
Note to self: (unrelated to this bug) the white test should be corrected, we now calculate a chroma of
0
rather than the slightly-off chroma of0.0146
due to #354 which also means we can improve the rather slack epsilon in this test)The text was updated successfully, but these errors were encountered: