Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Logo #58

Closed
sakinshrestha opened this issue Nov 6, 2016 · 2 comments
Closed

Custom Logo #58

sakinshrestha opened this issue Nov 6, 2016 · 2 comments
Assignees
@cristianraiber
Labels
tested

Comments

@sakinshrestha
Copy link

  • From WordPress version 4.5, logo can be added via theme support and in included in core, so you need to use core function rather than adding you own custom version. More info: https://make.wordpress.org/core/2016/03/10/custom-logo/
  • Also, in customizer.php, I have no idea why you have chosen to use shapely_sanitize_number to sanitize header_logo
@cristianraiber cristianraiber mentioned this issue Dec 8, 2016
Merged
@cristianraiber
Copy link
Member

cristianraiber commented Dec 8, 2016 •
edited
Loading

@c0sm1n87 - shapely_sanitize_number doesn't seem to be used anywhere in the project. Shouldn't we remove it?

Custom logo support - has been added ✅

@cristianraiber cristianraiber self-assigned this Dec 8, 2016
@cristianraiber cristianraiber mentioned this issue Dec 9, 2016
Merged
@cristianraiber
Copy link
Member

Function has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cristianraiber cristianraiber

Labels
tested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cristianraiber @sakinshrestha