Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong sorting for coverage #79

Closed
PragTob opened this issue Jan 9, 2020 · 6 comments · Fixed by #80
Closed

Wrong sorting for coverage #79

PragTob opened this issue Jan 9, 2020 · 6 comments · Fixed by #80

Comments

@PragTob
Copy link
Collaborator

PragTob commented Jan 9, 2020

It seems that coverage percents aren't correctly sorted according to their float value but rather treated as strings as reported over here: simplecov-ruby/simplecov#781 (comment)

example wrong sorting

we should fix that :)
@PragTob PragTob mentioned this issue Jan 9, 2020
Closed
17 tasks
@klyonrad
Copy link

klyonrad commented Jan 9, 2020 •
edited

It works correctly on the most recent version of simplecov (not beta)

Oh Jeez, the project also uses JQuery-DataTables 😨

Maybe something that in the values that trips up the automatic type detection from datatables. See https://datatables.net/reference/option/columns.type

As an optimisation, if you know the column type in advance, you can set the value using this option, saving DataTables from running its auto detection routine.

(the packaged version of the package is also quite old by the way)

@PragTob
Copy link
Collaborator Author

PragTob commented Jan 9, 2020

@klyonrad what, really? o_O How in the hell would I have broken that with the branch coverage...

Yup the whole HTML is really old mostly written in good old 2011.

Thanks for the input!

@dmitry
Copy link

dmitry commented Jan 9, 2020 •
edited

@PragTob aoColumns for dataTable should be reverted back: bc11506#diff-b6fb131d761768d224435ab049183090L13

That will solve an issue.

@PragTob
Copy link
Collaborator Author

PragTob commented Jan 10, 2020

@dmitry thank you! Should have caught that in my initial review 🙈

IMG_20180603_163802

PragTob added a commit that referenced this issue Jan 10, 2020
@PragTob
Reinstate aoColumns so that we have proper sorting in percent columns
0657d08 
Regression from first release.

See: bc11506#r36735556
Thanks @dmitry

Fixes #79

Sorry for the noise of the slight changes in the other parts of
the JS, VSCode made a decision and I was too lazy to go back
and make it a separate commit. :see-no-evil:

Relevant code is in layout.erb and the top of application.js
(where there's new code)
@PragTob PragTob mentioned this issue Jan 10, 2020
Merged
@dmitry
Copy link

dmitry commented Jan 10, 2020

Great, @PragTob! Thank you for the quick fix. It always can happen, anyway it's still beta and your work is really nice!

@PragTob
Copy link
Collaborator Author

PragTob commented Jan 10, 2020

Thank you for the quick spot! 👌

PragTob added a commit that referenced this issue Jan 11, 2020
@PragTob
Reinstate aoColumns so that we have proper sorting in percent columns (…
6dc1df0 
…#80)

* Reinstate aoColumns so that we have proper sorting in percent columns

Regression from first release.

See: bc11506#r36735556
Thanks @dmitry

Fixes #79

Sorry for the noise of the slight changes in the other parts of
the JS, VSCode made a decision and I was too lazy to go back
and make it a separate commit. :see-no-evil:

Relevant code is in layout.erb and the top of application.js
(where there's new code)

* expand comment on column and sorting handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reinstate aoColumns so that we have proper sorting in percent columns simplecov-ruby/simplecov-html
3 participants
@dmitry @PragTob @klyonrad