Make sure the license file gets included with the gem #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't update the changelog because I wasn't sure what you'd want it to look like, but we'd love if this went out as 0.16.1. |
tas50
added a commit
to chef/license_scout
that referenced
this pull request
Mar 15, 2018
In Simplecov 0.16 vthey accidently excluded the MIT-LICENSE file from their gem which is causing failures in Jenkins for us in Chef. The PR to fix that is simplecov-ruby/simplecov#672, but until that gets merged and released we'll need an override. Signed-off-by: Tim Smith <tsmith@chef.io>
|
Sorry that happened! I think renaming the file to |
When the list of files to include was pruned down the LICENSE file was accidently pruned as well. This causes issues for projects that do strict license validation on depdendencies. Rename MIT-LICENSE to LICENSE so it gets bundled. Signed-off-by: Tim Smith <tsmith@chef.io>
|
@PragTob Updated to use LICENSE |
|
@tas50 and released as 0.16.1 |
This was referenced Mar 16, 2018
This was referenced Mar 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the list of files to include was pruned down the LICENSE file was
accidently pruned as well. This causes issues for projects that do
strict license validation on depdendencies.
Signed-off-by: Tim Smith tsmith@chef.io