Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use around #488

Merged
merged 1 commit into from Apr 20, 2016
Merged

use around #488

merged 1 commit into from Apr 20, 2016

Conversation

grosser
Copy link
Contributor

@grosser grosser commented Apr 12, 2016

@grosser
Copy link
Contributor Author

grosser commented Apr 19, 2016

@xaviershay @colszowka I can haz merge ?

xaviershay
xaviershay reviewed Apr 19, 2016
View reviewed changes
spec/return_codes_spec.rb
before do
@current_dir = Dir.getwd
Dir.chdir(File.join(File.dirname(__FILE__), "fixtures", "frameworks"))
FileUtils.rm_rf("./coverage")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it ok to drop this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is not, fixed!

@xaviershay
Copy link
Collaborator

great, thanks

@xaviershay xaviershay merged commit a80baea into simplecov-ruby:master Apr 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grosser @xaviershay