New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Integer instead of Fixnum #523

Merged
merged 1 commit into from Sep 29, 2016

Conversation

Projects
None yet
4 participants
@nobu
Copy link
Contributor

nobu commented Sep 29, 2016

The range of Fixnum is not guaranteed at all. And ruby 2.4
unifies Fixnum and Bignum into Integer, and will deprecate
those two constants.

Use Integer instead of Fixnum
The range of `Fixnum` is not guaranteed at all.  And ruby 2.4
unifies `Fixnum` and `Bignum` into `Integer`, and will deprecate
those two constants.
@amatsuda

This comment has been minimized.

Copy link
Collaborator

amatsuda commented Sep 29, 2016

🤘

@amatsuda amatsuda merged commit f45cc3e into colszowka:master Sep 29, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nobu nobu deleted the nobu:bug/no-fixnum branch Sep 29, 2016

@colszowka

This comment has been minimized.

Copy link
Owner

colszowka commented Sep 29, 2016

Neat!

@tagliala

This comment has been minimized.

Copy link

tagliala commented Jan 1, 2017

Do you mind to release a new gem version with this fix?

~/.rvm/gems/ruby-2.4.0/gems/simplecov-0.12.0/lib/simplecov/configuration.rb:207: warning: constant ::Fixnum is deprecated
~/.rvm/gems/ruby-2.4.0/gems/simplecov-0.12.0/lib/simplecov/source_file.rb:29: warning: constant ::Fixnum is deprecated
~/.rvm/gems/ruby-2.4.0/gems/simplecov-0.12.0/lib/simplecov/source_file.rb:30: warning: constant ::Fixnum is deprecated
Coverage report generated for Integration Tests to /Users/geremia/dev/route_translator/coverage. 245 / 248 LOC (98.79%) covered.

PS: Happy new year!

@colszowka

This comment has been minimized.

Copy link
Owner

colszowka commented Jan 1, 2017

jsonn pushed a commit to jsonn/pkgsrc that referenced this pull request Mar 20, 2017

taca
Update ruby-simplecov to 0.14.1.
0.14.1 2017-03-18 ([changes](colszowka/simplecov@v0.14.0...v0.14.1))
========

## Bugfixes

* Files that were skipped as a whole/had no relevant coverage could lead to Float errors. See [#564](colszowka/simplecov#564) (thanks to @stevehanson for the report in [#563](colszowka/simplecov#563))

0.14.0 2017-03-15 ([changes](colszowka/simplecov@v0.13.0...v0.14.0))
==========

## Enhancements

* Officially support JRuby 9.1+ going forward (should also work with previous releases). See [#547](colszowka/simplecov#547) (ping @PragTob when encountering issues)
* Add Channel group to Rails profile, when `ActionCable` is loaded. See [#492](colszowka/simplecov#492) (thanks @BenMorganIO)
* Stop `extend`ing instances of `Array` and `Hash` during merging results avoiding problems frozen results while manually merging results. See [#558](colszowka/simplecov#558) (thanks @aroben)

## Bugfixes

* Fix parallel_tests when a thread ends up running no tests. See [#533](colszowka/simplecov#533) (thanks @cshaffer)
* Skip the `:nocov:` comments along with the code that they skip. See [#551](colszowka/simplecov#551) (thanks @ebiven)
* Fix crash when Home environment variable is unset. See [#482](colszowka/simplecov#482) (thanks @waldyr)
* Make track_files work again when explicitly setting it to nil. See [#463](colszowka/simplecov#463) (thanks @craiglittle)
* Do not overwrite .last_run.json file when refuse_coverage_drop option is enabled and the coverage has dropped (lead to you being able to just rerun tests and everything was _fine_). See [#553](colszowka/simplecov#553) (thanks @Miloshes)

0.13.0 2016-01-25 ([changes](colszowka/simplecov@v0.12.0...v0.13.0))
==========

## Enhancements

* Faster run times when a very large number of files is loaded into SimpleCov. See [#520](colszowka/simplecov#520) (thanks @alyssais)
* Only read in source code files that are actually used (faster when files are ignored etc.). See [#540](colszowka/simplecov#540) (tahks @yui-knk)

## Bugfixes

* Fix merging of resultsets if a file is missing on one side. See [#513](colszowka/simplecov#513) (thanks @hanazuki)
* Fix Ruby 2.4 deprecation warnings by using Integer instead of Fixnum. See [#523](colszowka/simplecov#523) (thanks @nobu)
* Force Ruby 2 to json 2. See [dc7417d50](colszowka/simplecov@dc7417d) (thanks @amatsuda)
* Various other gem dependency fixes for different gems on different ruby versions. (thanks @amatsuda)

oooooooo added a commit to oooooooo/forevernote that referenced this pull request May 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment