Filter directories outside SimpleCov.root that have it as a prefix #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given project directory `/foo/app` and BUNDLE_PATH `/foo/app_cache`, ensure the latter is filtered out correctly by the default root filter, since it's outside of SimpleCov.root. Otherwise you'll see all those gem files in your coverage report, with nonsensical paths like `._cache/ruby/2.4.0/gems...`, unless you add a nonsensical `/^_cache/` filter Also add some test coverage for the default filters
|
Paths are hard, I fixed essentially the same bug in bundler a while back 😂 ... rubygems/bundler#4715 |
PragTob
approved these changes
Aug 29, 2017
| @@ -6,7 +6,7 @@ | |||
| # Exclude all files outside of simplecov root | |||
| root_filter = nil | |||
| add_filter do |src| | |||
| root_filter ||= /\A#{Regexp.escape(SimpleCov.root)}/io | |||
| root_filter ||= /\A#{Regexp.escape(SimpleCov.root + File::SEPARATOR)}/io | |||
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Sep 18, 2017
0.15.1 (2017-09-11) ======= ## Bugfixes * Filter directories outside SimpleCov.root that have it as a prefix. See [#617](simplecov-ruby/simplecov#617) (thanks @jenseng) * Fix standard rails profile rails filter (didn't work). See [#618](simplecov-ruby/simplecov#618) (thanks @jenseng again!)
This was referenced Mar 14, 2018
This was referenced Mar 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given project directory
/foo/appand BUNDLE_PATH/foo/app_cache,ensure the latter is filtered out correctly by the default root filter,
since it's outside of SimpleCov.root.
Otherwise you'll see all those gem files in your coverage report, with
nonsensical paths like
._cache/ruby/2.4.0/gems..., unless you add anonsensical
/^_cache/filterAlso add some test coverage for the default filters