Fixes #493 Capture exit exception for reference #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PragTob
reviewed
Nov 3, 2017
spec/simplecov_spec.rb
Outdated
| end | ||
|
|
||
| context "when an exception has not occurred" do | ||
| it "does set the exit_exception" do |
There was a problem hiding this comment.
has no exit_exception might be better here :)
spec/simplecov_spec.rb
Outdated
| end | ||
|
|
||
| it "returns the exit exception" do | ||
| expect(SimpleCov.exit_exception).to be(error) |
There was a problem hiding this comment.
imo we already tested this basically in the tests before this, so I'd be good without this spec :)
|
Thanks for the feedback. I'll implement the fixes in the next couple days 👍 |
This stores any exit exception that may have occurred. The idea is to
expose this exception to the user supplied ```at_exit``` block.
```ruby
SimpleCov.at_exit do
if SimpleCov.exit_exception
# Do something or nothing due to an exception
else
# Do something or nothing due to no exception
end
end
```
Another method was added: ```exit_status_from_exception``` to reduce the
logic in the at_exit block. I am not sure if it's worth adding this
method though. There is still opportunity to refactor the ```at_exit```
block. I first attempted to refactor the @exit_status logic more but
it will be a bigger change. If you want I can remove the
```exit_status_from_exception``` method from this PR
thomas07vt
force-pushed
the
issues/493-store_exit_exception
branch
from
eb7e5b8
to
ecee188
Compare
|
and by next couple of days... i apparently meant the next 10 days.... :) OK, ready for another review. |
PragTob
approved these changes
Nov 18, 2017
This was referenced Mar 15, 2018
This was referenced Mar 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #493
This stores any exit exception that may have occurred. The idea is to
expose this exception to the user supplied
at_exitblock.Another method was added:
exit_status_from_exceptionto reduce thelogic in the at_exit block. I am not sure if it's worth adding this
method though. There is still opportunity to refactor the
at_exitblock. I first attempted to refactor the @exit_status logic more but
it will be a bigger change. If you want I can remove the
exit_status_from_exceptionmethod from this PRI also don't love having
begin rescue endblocks in tests, but I wasn't sureif there was a better way to test that. Maybe I could wrap
$!/$ERROR_INFOin another method and mock that in testing.