Ldaresults #46
Merged
Ldaresults #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 17, 2015 13:04
| # tokenized_text = ['newtoken', 'newtoken'] | ||
| # with self.assertRaises(TokenError) as cm: | ||
| # results = lda.predict(tokenized_text, raise_on_unknown=True) | ||
| def test_predict_6(self): |
There was a problem hiding this comment.
At some point these tests should be renamed to something meaningful...or doc added. In this case, I don't know why something was supposed to be raised.
There was a problem hiding this comment.
yeah that's I commented them out earlier; they were not really informative or testing much
|
I had a few comments. Use what you like. LGTM. |
|
@langmore ok let me know if this looks ok to merge |
|
LGTM (= "Looks good to me", so go ahead and merge after making/not making the suggested changes). |
|
merging @langmore - maybe we are due for a micro/small release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanup:
* cleaned up and made more uniform