You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I originally brought this up on Discord and @lolgab mentioned he was going to look into it, but I figured I'd create an issue about it just to have something in this repo that we can reference.
The issue is that if you look in the BSP logs you'll see lots of things like this:
However, there is no build/tastStart or build/taskEnd that goes along with these. Taken from the docs
If a build/taskStart notification has been sent, the server must send build/taskFinish on completion of the same task.
The same goes for the build/taskEnd. In Discord the following was mentioned
I checked the implementation and I think it is not done at the optimal layer, since it parses the ticker logs to generate progresses. It can be done by wrapping the evaluate function so we can send the start and end of tasks and get the progress numbers directly, without parsing the logs.
The text was updated successfully, but these errors were encountered:
ckipp01
changed the title
Lots of task progress notifications with no start/end
[BSP] Lots of task progress notifications with no start/end
Feb 19, 2024
I originally brought this up on Discord and @lolgab mentioned he was going to look into it, but I figured I'd create an issue about it just to have something in this repo that we can reference.
The issue is that if you look in the BSP logs you'll see lots of things like this:
However, there is no
build/tastStart
orbuild/taskEnd
that goes along with these. Taken from the docsThe same goes for the
build/taskEnd
. In Discord the following was mentionedI'm assuming this is referring to this code here:
mill/bsp/worker/src/mill/bsp/worker/MillBspLogger.scala
Lines 26 to 41 in 07f6f95
The text was updated successfully, but these errors were encountered: