feat(#405): Remove LDname limitation #406
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -169,8 +170,8 @@ public String getXPath() { | |||
| */ | |||
| public void updateLDName() throws ScdException { | |||
| String newLdName = parentAdapter.getCurrentElem().getName() + currentElem.getInst(); | |||
| if (newLdName.length() > 33) { | |||
| throw new ScdException(newLdName + "(IED.name + LDevice.inst) has more than 33 characters"); | |||
| if (newLdName.length() > MAXIMUM_LENGHT_LD_NAME_BY_XSD) { | |||
There was a problem hiding this comment.
Knowing that the maxLength is an XSD constraint I think we shouldn't even care about verifying this.
There was a problem hiding this comment.
the problem is this occurs during the SCD creation
log.info(STEP_3);
sclEditor.importSTDElementsInSCD(scd, stds);and the SCD XSD validation occurs far away, in this method :
com.rte_france.rspace.rconf.service.ScdService#createSCD
So maybe the users would like to be warned as soon as the error occurs ?
There was a problem hiding this comment.
After discussing together, I will completely remove the check
sct-commons/src/test/java/org/lfenergy/compas/sct/commons/scl/ldevice/LDeviceAdapterTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: gleizesDor <115622893+gleizesDor@users.noreply.github.com>
gleizesDor
force-pushed
the
405-remove-ldname-limitation
branch
from
61a0d23
to
5e7ce2c
Compare
samirromdhani
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.