Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timer effect api revamp #42

Open
combatopera opened this issue Apr 7, 2019 · 1 comment
Open

timer effect api revamp #42

combatopera opened this issue Apr 7, 2019 · 1 comment
Labels
Concern priority for Concern project defect not quite a bug but clearly lacking

Comments

@combatopera
Copy link
Owner

combatopera commented Apr 7, 2019

  • instead of the current shambles, add a timerframe method to Note (or perhaps a method each for noteon/noteoff) in which you can write code just like in the regular methods, and instead of executing the code we use static analysis to apply a performant timer effect, and reject anything too fancy - as a first step, a low-level api so that songs can implement their own effects similar to PWMEffect, SinusEffect
  • it would also be good to have a nudge method to apply changes, the use-case for this is tone waveform reset by setting period to a small number. this may be a separate ticket - yes, see mechanism to apply values momentarily Lurlene#22
@combatopera combatopera added Concern priority for Concern project defect not quite a bug but clearly lacking labels Apr 7, 2019
@combatopera
Copy link
Owner Author

combatopera commented Oct 13, 2020

a good first step would be to silence timer effects at the start of a live coding frame, like we do for everything else - done in head

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Concern priority for Concern project defect not quite a bug but clearly lacking
Projects
None yet
Development

No branches or pull requests

1 participant