Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIGestureRecognizer publisher #6

Closed
mattjgalloway opened this issue Aug 12, 2019 · 6 comments
Closed

UIGestureRecognizer publisher #6

mattjgalloway opened this issue Aug 12, 2019 · 6 comments

Comments

@mattjgalloway
Copy link

Have you considered adding a publisher for gesture recognisers? Would be neat.

I’m happy to have a look at adding myself, just wanted to raise the issue to track.

@freak4pc
Copy link
Member

freak4pc commented Aug 12, 2019

Hey @mattjgalloway! Would be happy to have it :)

The only tricky part is that its not KVO-compliant, and also doesn't use UIControlEvent.

We'll have to make some custom publisher that sets the target and action on the UIBarButtonItem and expose these as a Publisher.

@mattjgalloway
Copy link
Author

Yep exactly. It’ll be different - just like in RxCocoa. That’s ok though - we can use the same paradigm for solving it.

@freak4pc
Copy link
Member

@mattjgalloway Do you want to tackle it, or should I? :)

@mattjgalloway
Copy link
Author

I can handle it sometime in the next month. If you want to get to it before then, then go for it! Happy to review anything.

@freak4pc
Copy link
Member

freak4pc commented Aug 12, 2019

Oh just realized you have two different threads :) I thought I'm replying to UIBarButtonItem ^_^

Anyways both sound like a good idea.

@freak4pc
Copy link
Member

Solved in #8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants