Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we release scala 2.12 support in central maven repository #697

Closed
billyean opened this issue Jun 11, 2020 · 9 comments · Fixed by #708
Closed

Can we release scala 2.12 support in central maven repository #697

billyean opened this issue Jun 11, 2020 · 9 comments · Fixed by #708
Assignees

Comments

@billyean
Copy link

billyean commented Jun 11, 2020

Currently I only see scala 2.11 support for mleap-xgboost-spark and mleap-xgboost-runtime in central maven repository, can you add release for scala 2.12, spark 2.4.5 has to use scala2.12

@lucagiovagnoli
Copy link
Member

lucagiovagnoli commented Jul 8, 2020

Hey billyean, I've been having a look at this today

Unfortunately it's not so easy. A package on which we depend (xgboost, see https://github.com/combust/mleap/blob/master/project/Dependencies.scala#L70) is not published for 2.12

But on the plus side, it seems that xgboost cross publishes for scala 2.12 starting from version 1.0.0 (https://mvnrepository.com/artifact/ml.dmlc/xgboost4j_2.12/1.0.0)

@lucagiovagnoli
Copy link
Member

I'm trying to tackle that in #708

@billyean
Copy link
Author

thank you for update @lucagiovagnoli

@nicodv
Copy link

nicodv commented Sep 11, 2020

+1 for this.

@lucagiovagnoli , maybe a good idea to separate the 2 goals of the PR? I'd be very interested in the xgboost upgrade.

@tovbinm
Copy link

tovbinm commented Sep 11, 2020

+1

@lucagiovagnoli
Copy link
Member

Hi everyone, sorry about the delay, I've been busy with some urgent internal work. I should get back to this by this week, hopefully today

@lucagiovagnoli
Copy link
Member

+1 for this.

@lucagiovagnoli , maybe a good idea to separate the 2 goals of the PR? I'd be very interested in the xgboost upgrade.

Yes, in that PR I'm only upgrading xgboost 1.0.0

@nicodv
Copy link

nicodv commented Sep 14, 2020

In case you're considering moving to a version beyond 1.0.0 (e.g. 1.1.1), it's available following these instructions: dmlc/xgboost#6081 (comment)

@lucagiovagnoli
Copy link
Member

Found some issues with 1.1.1, there's some code out here: #718 but I probably won't have time to dig deeper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants