Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: split /api into standalone module #1561

Closed
Tracked by #1330
glnro opened this issue Oct 31, 2023 · 1 comment · Fixed by #1608
Closed
Tracked by #1330

refactor: split /api into standalone module #1561

glnro opened this issue Oct 31, 2023 · 1 comment · Fixed by #1608
Assignees
@mzabaluev
Labels
P:integrator-experience Priority: Improve experience for integrators protobuf Protocol buffers-related

Comments

@glnro
Copy link
Contributor

glnro commented Oct 31, 2023 •
edited

The /api folder must effectively be a standalone Go module (i.e. have its own go.mod file, module github.com/cometbft/cometbft/api). We should consider whether the ABCI types should have their own standalone module or not, and we should consider the implications of independent versioning of code in the /api folder
@glnro glnro mentioned this issue Oct 31, 2023
Closed
17 tasks
@glnro glnro changed the title The /api folder must effectively be a standalone Go module (i.e. have its own go.mod file, module github.com/cometbft/cometbft/api). We should consider whether the ABCI types should have their own standalone module or not, and we should consider the implications of independent versioning of code in the /api folder. refactor: pull /api into it's own module Oct 31, 2023
@glnro glnro changed the title refactor: pull /api into it's own module refactor: split /api into it's own module Oct 31, 2023
@glnro glnro changed the title refactor: split /api into it's own module refactor: split /api into its own module Oct 31, 2023
@glnro glnro changed the title refactor: split /api into its own module refactor: split /api into standalone module Oct 31, 2023
@glnro glnro mentioned this issue Oct 31, 2023
Closed
3 tasks
@andynog andynog added protobuf Protocol buffers-related P:integrator-experience Priority: Improve experience for integrators labels Nov 2, 2023
@mzabaluev mzabaluev mentioned this issue Nov 13, 2023
Merged
3 tasks
@mzabaluev mzabaluev self-assigned this Nov 13, 2023
@mzabaluev
Copy link
Contributor

Done in #1608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mzabaluev mzabaluev

Labels
P:integrator-experience Priority: Improve experience for integrators protobuf Protocol buffers-related
Projects
No open projects
CometBFT 2023
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Split /api off to separate go.mod cometbft/cometbft
3 participants
@mzabaluev @glnro @andynog