Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use standardized Docker image to build protos #175

Open
thanethomson opened this issue Jan 21, 2023 · 1 comment
Open

ci: Use standardized Docker image to build protos #175

thanethomson opened this issue Jan 21, 2023 · 1 comment
Assignees
Labels
protobuf Protocol buffers-related tools Anything relating to tooling within the repo

Comments

@thanethomson
Copy link
Contributor

Follows from #173.

We need to update the proto-gen Makefile target to build our protos using a standardized Docker image (one we can build and push to our Docker Hub org) so that our whole team and CI all use precisely the same tooling to build the protos.

Similar to how the SDK does it here.

Given that such an image will require mounting a volume from the host system to (1) read the proto files and (2) output generated Go code, I recommend allowing the UID to be set by way of build args, like this image handles it, to cater for non-Mac systems that don't handle mapping of user IDs well. Otherwise the produced files have different user/group IDs in the filesystem on the host system that require root privileges to adjust before they're usable.

@thanethomson thanethomson added tools Anything relating to tooling within the repo protobuf Protocol buffers-related labels Jan 21, 2023
@melekes
Copy link
Contributor

melekes commented Feb 5, 2024

@greg-szabo if you're looking for a low-hanging fruit, this might be the one

@greg-szabo greg-szabo self-assigned this Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protobuf Protocol buffers-related tools Anything relating to tooling within the repo
Projects
No open projects
Status: Todo
Development

No branches or pull requests

3 participants