Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncomment all parts related to vote extensions, and FinalizeBlock from the spec. #403

Closed
Tracked by #24
jmalicevic opened this issue Feb 27, 2023 · 1 comment · Fixed by #421
Closed
Tracked by #24

Uncomment all parts related to vote extensions, and FinalizeBlock from the spec. #403

jmalicevic opened this issue Feb 27, 2023 · 1 comment · Fixed by #421
Assignees
@jmalicevic
Labels
abci Application blockchain interface spec Specification-related

Comments

@jmalicevic
Copy link
Contributor

jmalicevic commented Feb 27, 2023 •
edited
Loading

Uncomment and adjust the spec in main to address FinalizeBlock and VoteExtensions
@jmalicevic jmalicevic mentioned this issue Feb 27, 2023
Closed
11 tasks
@jmalicevic jmalicevic self-assigned this Feb 27, 2023
@jmalicevic jmalicevic added abci Application blockchain interface spec Specification-related labels Feb 27, 2023
@jmalicevic jmalicevic changed the title Uncomment all parts related to vote extensions, and FinalizeBlock from the spec. Uncomment all parts related to vote extensions, and FinalizeBlock and VoteExtensions from the spec. Feb 27, 2023
@jmalicevic jmalicevic changed the title Uncomment all parts related to vote extensions, and FinalizeBlock and VoteExtensions from the spec. Uncomment all parts related to vote extensions, and FinalizeBlock from the spec. Feb 27, 2023
@jmalicevic jmalicevic mentioned this issue Feb 28, 2023
Merged
@jmalicevic
Copy link
Contributor Author

Closed with #421

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmalicevic jmalicevic

Labels
abci Application blockchain interface spec Specification-related
Projects
No open projects
CometBFT 2023
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

spec:ABCI2.0 - Uncommenting content related to vote xtensions and finalize block cometbft/cometbft
1 participant
@jmalicevic