Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the existing gRPC broadcast API #650

Closed
2 tasks done
Tracked by #81
, #574
...
thanethomson opened this issue Apr 5, 2023 · 0 comments · Fixed by #659
Closed
2 tasks done
Tracked by #81
, #574
...

Remove the existing gRPC broadcast API #650

thanethomson opened this issue Apr 5, 2023 · 0 comments · Fixed by #659
Assignees
@thanethomson
Labels
grpc Anything relating to the gRPC API protobuf Protocol buffers-related rpc
Milestone
2023-Q2

Comments

@thanethomson
Copy link
Contributor

thanethomson commented Apr 5, 2023 •
edited by jmalicevic

As part of #81, we should first remove the existing gRPC broadcast API on main. To this end, we should:

This will be superseded by a more comprehensive broadcast API that will be versioned as per #95.

This would also help with #574.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thanethomson thanethomson

Labels
grpc Anything relating to the gRPC API protobuf Protocol buffers-related rpc
Projects
No open projects
CometBFT 2023
Status: Done
Milestone
2023-Q2
Development

Successfully merging a pull request may close this issue.

Remove gRPC broadcast API cometbft/cometbft
1 participant
@thanethomson