Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: Allow disabling PEX reactor #1579

Closed
lasarojc opened this issue Nov 7, 2023 · 2 comments · Fixed by #1580
Closed

e2e: Allow disabling PEX reactor #1579

lasarojc opened this issue Nov 7, 2023 · 2 comments · Fixed by #1580
Assignees
Labels
e2e Related to our end-to-end tests enhancement New feature or request P:bandwidth-optimization Priority: Optimize bandwidth usage

Comments

@lasarojc
Copy link
Contributor

lasarojc commented Nov 7, 2023

Feature Request

During experimentation it may be useful to disable peer discovery on the whole setup and only connect to peers specified in the config.toml

Summary

Allow disabling the PEX reactor in the manifests.

Problem Definition

When experimenting, restarting leads to a different overlay network being set every time, casting doubt on comparison results.

Proposal

Allow disabling the PEX on manifests so that connections are only stablished to the peers specified in generated config.toml

@lasarojc lasarojc added enhancement New feature or request needs-triage This issue/PR has not yet been triaged by the team. and removed needs-triage This issue/PR has not yet been triaged by the team. labels Nov 7, 2023
@lasarojc lasarojc self-assigned this Nov 7, 2023
@lasarojc lasarojc added the P:bandwidth-optimization Priority: Optimize bandwidth usage label Nov 7, 2023
@cason
Copy link
Contributor

cason commented Nov 7, 2023

Please refer that this applies to end-to-end tests or qa-infrastructure.

We can disable PEX on regular nodes, there is a configuration key for that: https://github.com/cometbft/cometbft/blob/main/config/toml.go#L360

@hvanz hvanz changed the title Allow disabling PEX reactor e2e: Allow disabling PEX reactor Nov 7, 2023
@hvanz hvanz added the e2e Related to our end-to-end tests label Nov 7, 2023
@lasarojc
Copy link
Contributor Author

lasarojc commented Nov 7, 2023

Please refer that this applies to end-to-end tests or qa-infrastructure.

We can disable PEX on regular nodes, there is a configuration key for that: https://github.com/cometbft/cometbft/blob/main/config/toml.go#L360

Updated to reflect the limitation on specifying the flag on manifests, not individual configs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Related to our end-to-end tests enhancement New feature or request P:bandwidth-optimization Priority: Optimize bandwidth usage
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants