Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins #25

Open
Tracked by #44
cometkim opened this issue Feb 7, 2022 · 1 comment
Open
Tracked by #44

Plugins #25

cometkim opened this issue Feb 7, 2022 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@cometkim
Copy link
Owner

cometkim commented Feb 7, 2022

Configurability by additional plugin support could be a good escape hatch for edges like #12.

Fortunately, nanobundle is a plain ESM, so it's very easy to achieve that via dynamic import .

Provide a way to configure additional plugins in addition to the currently built-in import maps and embedding deps plugins. Mostly it's just an esbuild plugin, but I need to provide additional dependencies for initialization.

@cometkim cometkim added the enhancement New feature or request label Feb 7, 2022
@cometkim cometkim added this to the v1 milestone Feb 7, 2022
@cometkim cometkim mentioned this issue Nov 22, 2022
6 tasks
@cometkim cometkim modified the milestones: v1, v1.x Dec 4, 2022
@cometkim
Copy link
Owner Author

Note:

Even if nanobundle get a plugin interface, it will not be compatible with most external plugins since nanobundle already fix module resolutions

https://github.com/cometkim/nanobundle/blob/3d07b82/src/plugins/esbuildNanobundlePlugin.ts

See evanw/esbuild#2216 to track upstream issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant